Fix for mssql-jdbc.properties location logic
#2579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utOfBoundsExcelption
Jeffery-Wasty
requested review from
lilgreenbird,
divang,
Ananya2,
tkyc,
muskan124947 and
machavan
tkyc
reviewed
Jan 10, 2025
tkyc
reviewed
Jan 10, 2025
machavan
reviewed
Jan 10, 2025
src/main/java/com/microsoft/sqlserver/jdbc/ConfigurableRetryLogic.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
============================================
+ Coverage 51.22% 51.36% +0.13%
- Complexity 3953 3972 +19
============================================
Files 147 147
Lines 33657 33666 +9
Branches 5624 5627 +3
============================================
+ Hits 17241 17291 +50
+ Misses 13999 13940 -59
- Partials 2417 2435 +18 ☔ View full report in Codecov by Sentry. |
machavan
previously approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
Jeffery-Wasty
changed the title
mssql-jdbc.properties location logicmssql-jdbc.properties location logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for finding the
mssql-jdbc.propertiesfile, used in Configurable Retry Logic was correct for test environments, and when building the driver manually, but not correct when using the driver as a jar or dependency. This fixes that issue by only removing thetarget/classessuffix if needed.